Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): remove about what modal #3097

Merged
merged 5 commits into from
Oct 25, 2024
Merged

feat(frontend): remove about what modal #3097

merged 5 commits into from
Oct 25, 2024

Conversation

loki344
Copy link
Collaborator

@loki344 loki344 commented Oct 24, 2024

Motivation

As part of #3096 the info modals are unified. First step is to remove the about what modal.

Changes

  • Remove all references and usages of about what modal including tests

Tests

  • Removed tests for about what modal

image
image
image

@loki344 loki344 mentioned this pull request Oct 24, 2024
Merged
@loki344
Copy link
Collaborator Author

loki344 commented Oct 24, 2024

see https://dfinity.atlassian.net/browse/OISY-200

github-actions bot and others added 2 commits October 24, 2024 11:08
@github-actions
🤖 update E2E snapshots
f505ec2
@loki344
Merge remote-tracking branch 'origin/main' into feat(frontend)/remove…
1c71c63 
…-about-what-modal

# Conflicts:
#	e2e/homepage.spec.ts-snapshots/should-display-homepage-in-logged-out-state-1-Google-Chrome-linux.png
@loki344 loki344 marked this pull request as ready for review October 24, 2024 11:27
@loki344 loki344 requested a review from a team as a code owner October 24, 2024 11:27
AntonioVentilii-DFINITY
AntonioVentilii-DFINITY reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think icon IconStar can be removed too, right?

AntonioVentilii-DFINITY
AntonioVentilii-DFINITY approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nitpick: we have script check.unused that should tell you which one are the unused components

@loki344
Merge remote-tracking branch 'origin/main' into feat(frontend)/remove…
08b45c5 
…-about-what-modal

# Conflicts:
#	e2e/homepage.spec.ts-snapshots/should-display-homepage-in-logged-in-state-1-Google-Chrome-linux.png
@loki344 loki344 merged commit 8442dc5 into main Oct 25, 2024
13 of 14 checks passed
@loki344 loki344 deleted the feat(frontend)/remove-about-what-modal branch October 25, 2024 11:36
loki344 added a commit that referenced this pull request Oct 25, 2024
@loki344 @github-actions
feat(frontend): unify info modals (#3096)
98b4dc3 
# Motivation

Instead of two separate info modals, the information is unified and
improved by the suggestions of an iteration with stakeholders.

# Notes

MR for removing other modal already merged:
#3097

# Changes

Remove AboutHow modal
Refactor AboutWhy modal into AboutWhyOisy to include new texts


![image](https://github.com/user-attachments/assets/7674a554-d651-4b67-bddc-9355f864b682)

![image](https://github.com/user-attachments/assets/ba284cd2-e3bb-4afd-8f97-711e1d226ca4)

![image](https://github.com/user-attachments/assets/bbbcb123-6455-43c8-b8c0-e55bf3b20721)

![image](https://github.com/user-attachments/assets/01c18fb0-e037-4afb-b862-798ea7226653)

![image](https://github.com/user-attachments/assets/0d4ecd24-96c0-459b-9bb0-8af47cfd6435)

![image](https://github.com/user-attachments/assets/c4bd2609-2f23-4de6-8646-b16ac23829ab)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY AntonioVentilii-DFINITY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loki344 @AntonioVentilii-DFINITY