From 20be8ffbe31ed2e642a3a8d3002fd5b30d6a1260 Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Fri, 15 Nov 2024 13:51:11 +0100 Subject: [PATCH 01/14] changes footer copyright text --- .../src/lib/components/core/Footer.svelte | 35 ++++++++++--------- src/frontend/src/lib/i18n/en.json | 4 ++- src/frontend/src/lib/types/i18n.d.ts | 2 +- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 86b4d03c8f..296cb6c57a 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -65,23 +65,26 @@ class:md:translate-x-full={$authSignedIn} class:1.5md:translate-x-0={$authSignedIn} > - -
- - + + + {replaceOisyPlaceholders($i18n.footer.text.incubated_with)} + - {replaceOisyPlaceholders($i18n.footer.text.developed_with)} - -
- + {replaceOisyPlaceholders($i18n.footer.text.dfinity_foundation)} + + {replaceOisyPlaceholders($i18n.footer.text.copyright)} + + diff --git a/src/frontend/src/lib/i18n/en.json b/src/frontend/src/lib/i18n/en.json index cc6050e110..26ada0cd95 100644 --- a/src/frontend/src/lib/i18n/en.json +++ b/src/frontend/src/lib/i18n/en.json @@ -109,7 +109,9 @@ }, "footer": { "text": { - "developed_with": "© 2024 Developed with ❤\uFE0F at DFINITY" + "incubated_with": "Incubated with ❤\uFE0F by \uFE0F", + "dfinity_foundation": "DFINITY Foundation \uFE0F", + "copyright": "© 2024" }, "alt": { "dfinity": "Go to DFINITY Foundation website", diff --git a/src/frontend/src/lib/types/i18n.d.ts b/src/frontend/src/lib/types/i18n.d.ts index c9eff6a397..81f7c0ceaf 100644 --- a/src/frontend/src/lib/types/i18n.d.ts +++ b/src/frontend/src/lib/types/i18n.d.ts @@ -101,7 +101,7 @@ interface I18nDapps { } interface I18nFooter { - text: { developed_with: string }; + text: { incubated_with: string, dfinity_foundation: string, copyright: string }; alt: { dfinity: string; status: string }; } From 850e3a7a3741841b9a8550cae28040a3cd4d4fe8 Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Fri, 15 Nov 2024 14:45:23 +0100 Subject: [PATCH 02/14] adds copyright padding on mobile view --- src/frontend/src/lib/components/core/Footer.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 296cb6c57a..4dcaab069b 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,7 +53,7 @@
Date: Fri, 15 Nov 2024 13:56:07 +0000 Subject: [PATCH 03/14] =?UTF-8?q?=F0=9F=A4=96=20Updated=20i18n=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/lib/types/i18n.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/lib/types/i18n.d.ts b/src/frontend/src/lib/types/i18n.d.ts index 81f7c0ceaf..97893fc5e3 100644 --- a/src/frontend/src/lib/types/i18n.d.ts +++ b/src/frontend/src/lib/types/i18n.d.ts @@ -101,7 +101,7 @@ interface I18nDapps { } interface I18nFooter { - text: { incubated_with: string, dfinity_foundation: string, copyright: string }; + text: { incubated_with: string; dfinity_foundation: string; copyright: string }; alt: { dfinity: string; status: string }; } From e8b416917973584251a65befd829f9c55b393057 Mon Sep 17 00:00:00 2001 From: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 15 Nov 2024 13:57:39 +0000 Subject: [PATCH 04/14] =?UTF-8?q?=F0=9F=A4=96=20Apply=20formatting=20chang?= =?UTF-8?q?es?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/lib/components/core/Footer.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 4dcaab069b..4b99586713 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,7 +53,7 @@
Date: Fri, 15 Nov 2024 15:20:54 +0100 Subject: [PATCH 05/14] makes the copyright text centered --- src/frontend/src/lib/components/core/Footer.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 4b99586713..a6eb75d6db 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -72,6 +72,7 @@ class:xl:flex={$authSignedIn} class:md:h-md:hidden={$authNotSignedIn} class:1.5md:h-md:flex={$authNotSignedIn} + class="text-center" > {replaceOisyPlaceholders($i18n.footer.text.incubated_with)} Date: Fri, 15 Nov 2024 16:10:29 +0100 Subject: [PATCH 06/14] adds a margin on top on viewport sm --- src/frontend/src/lib/components/core/Footer.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index a6eb75d6db..03a8659183 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,7 +53,7 @@
Date: Tue, 19 Nov 2024 10:34:56 +0100 Subject: [PATCH 07/14] makes dfinity icon size customizable improves footer design --- .../src/lib/components/core/Footer.svelte | 16 ++++++++++------ .../src/lib/components/icons/IconDfinity.svelte | 6 +++++- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 03a8659183..3164a1ccf7 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,10 +53,11 @@
-
- +
+ + {replaceOisyPlaceholders($i18n.footer.text.incubated_with)} @@ -83,7 +87,7 @@ > {replaceOisyPlaceholders($i18n.footer.text.dfinity_foundation)} - {replaceOisyPlaceholders($i18n.footer.text.copyright)} + {replaceOisyPlaceholders($i18n.footer.text.copyright)}
diff --git a/src/frontend/src/lib/components/icons/IconDfinity.svelte b/src/frontend/src/lib/components/icons/IconDfinity.svelte index 6351e4c99a..a6e8ae9658 100644 --- a/src/frontend/src/lib/components/icons/IconDfinity.svelte +++ b/src/frontend/src/lib/components/icons/IconDfinity.svelte @@ -1,5 +1,9 @@ - + + + Date: Tue, 19 Nov 2024 11:29:13 +0100 Subject: [PATCH 08/14] fixes copyright text spacing --- src/frontend/src/lib/components/core/Footer.svelte | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 3164a1ccf7..4174e12ac6 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -68,15 +68,14 @@ class:xl:max-w-80={$authSignedIn} class:1.5xl:max-w-none={$authSignedIn} > -
- - +
+ {replaceOisyPlaceholders($i18n.footer.text.incubated_with)} {replaceOisyPlaceholders($i18n.footer.text.dfinity_foundation)} From 413c4cbf745cf506aa5b25189d81b24688ae066c Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Tue, 19 Nov 2024 11:30:55 +0100 Subject: [PATCH 09/14] reformat code --- src/frontend/src/lib/components/core/Footer.svelte | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 4174e12ac6..0b80baa19c 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -87,7 +87,9 @@ > {replaceOisyPlaceholders($i18n.footer.text.dfinity_foundation)} - {replaceOisyPlaceholders($i18n.footer.text.copyright)} + {replaceOisyPlaceholders($i18n.footer.text.copyright)}
From 779bb413821c3adfb19356acbe0e04fe12115938 Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Tue, 19 Nov 2024 13:16:18 +0100 Subject: [PATCH 10/14] improves footer design --- src/frontend/src/lib/components/core/Footer.svelte | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 0b80baa19c..660554e088 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,7 +53,7 @@
-
+
{replaceOisyPlaceholders($i18n.footer.text.dfinity_foundation)} From 2eb83cb3db5acd99b1da60efee17e26029759e55 Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Tue, 19 Nov 2024 13:17:57 +0100 Subject: [PATCH 11/14] reformat code --- src/frontend/src/lib/components/core/Footer.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 660554e088..67e6934458 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -68,7 +68,7 @@ class:xl:max-w-80={$authSignedIn} class:1.5xl:max-w-none={$authSignedIn} > -
+
Date: Tue, 19 Nov 2024 13:47:53 +0100 Subject: [PATCH 12/14] removes unused spaces --- src/frontend/src/lib/i18n/en.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frontend/src/lib/i18n/en.json b/src/frontend/src/lib/i18n/en.json index 26ada0cd95..dfeeecfdb8 100644 --- a/src/frontend/src/lib/i18n/en.json +++ b/src/frontend/src/lib/i18n/en.json @@ -109,8 +109,8 @@ }, "footer": { "text": { - "incubated_with": "Incubated with ❤\uFE0F by \uFE0F", - "dfinity_foundation": "DFINITY Foundation \uFE0F", + "incubated_with": "Incubated with ❤\uFE0F by", + "dfinity_foundation": "DFINITY Foundation", "copyright": "© 2024" }, "alt": { From bf0a7b7c61d42058c2b88ea135b935d706e556a6 Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Tue, 19 Nov 2024 16:02:46 +0100 Subject: [PATCH 13/14] fixes review feedback --- src/frontend/src/lib/components/core/Footer.svelte | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 67e6934458..5e249ed27a 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,20 +53,20 @@
From 0834cc6282f2254c0f9ed2dbb1cba2daaf9f5999 Mon Sep 17 00:00:00 2001 From: AlessandroBonomo Date: Tue, 19 Nov 2024 16:35:13 +0100 Subject: [PATCH 14/14] replaces pl-0 and pr-0 with px-0 --- src/frontend/src/lib/components/core/Footer.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/lib/components/core/Footer.svelte b/src/frontend/src/lib/components/core/Footer.svelte index 5e249ed27a..63d1a5637f 100644 --- a/src/frontend/src/lib/components/core/Footer.svelte +++ b/src/frontend/src/lib/components/core/Footer.svelte @@ -53,7 +53,7 @@