From edfdbb966118990c9898c6723121f5610188c155 Mon Sep 17 00:00:00 2001 From: Tingluo Huang Date: Tue, 4 Jun 2024 09:57:15 -0400 Subject: [PATCH] Make sure we mask secrets when reporting telemetry. (#3315) --- src/Runner.Common/JobServerQueue.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Runner.Common/JobServerQueue.cs b/src/Runner.Common/JobServerQueue.cs index dd060734b79..74c12bea28b 100644 --- a/src/Runner.Common/JobServerQueue.cs +++ b/src/Runner.Common/JobServerQueue.cs @@ -613,7 +613,7 @@ private async Task ProcessResultsUploadQueueAsync(bool runOnce = false) private void SendResultsTelemetry(Exception ex) { - var issue = new Issue() { Type = IssueType.Warning, Message = $"Caught exception with results. {ex.Message}" }; + var issue = new Issue() { Type = IssueType.Warning, Message = $"Caught exception with results. {HostContext.SecretMasker.MaskSecrets(ex.Message)}" }; issue.Data[Constants.Runner.InternalTelemetryIssueDataKey] = Constants.Runner.ResultsUploadFailure; var telemetryRecord = new TimelineRecord()