Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private library imports #62

Open
Tracked by #3921
ByronBecker opened this issue Nov 19, 2022 · 2 comments
Open
Tracked by #3921

Support private library imports #62

ByronBecker opened this issue Nov 19, 2022 · 2 comments

Comments

@ByronBecker
Copy link
Contributor

Vessel currently does not support imports from private libraries. This is due to a limitation of the headers passed by the rust_dhall crate Nadrieril/dhall-rust#134.

@rvanasa
Copy link
Contributor

rvanasa commented Nov 19, 2022

I spent a lot of time looking into this today, and it seems like a rather deep limitation of the current dhall-rust implementation.

For now, it's possible to get around this with the following hack:

  • Install the latest version of the Dhall CLI
  • Rename package-set.dhall to something like package-set-initial.dhall
  • Add package-set.dhall to your .gitignore
  • Add headers via the using syntax or DHALL_HEADERS environment variable
  • Create a bash / npm / make script which runs dhall resolve --file package-set-initial.dhall > package-set.dhall && vessel install

We are planning to move away from Dhall in favor of Motoko (via motoko.rs) as the preferred configuration language for Vessel, so I'll make sure that custom headers will be easy to use in package-set.mo files.

@ByronBecker
Copy link
Contributor Author

We are planning to move away from Dhall in favor of Motoko (via motoko.rs) as the preferred configuration language for Vessel

Wooooo 🎉

Looking forward to seeing this. And thanks for the intermediate workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants