Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt Einsum v3.5.0 #191

Open
dgasmith opened this issue Jul 3, 2022 · 2 comments
Open

Opt Einsum v3.5.0 #191

dgasmith opened this issue Jul 3, 2022 · 2 comments

Comments

@dgasmith
Copy link
Owner

dgasmith commented Jul 3, 2022

We should go ahead and kick out a v3.4.0 release given our current cadence. However, thinking ahead to the next release we have a few changes we should make:

  • Based on NumPy's NEP: On Dec 26, 2021 drop support for Python 3.7 (initially released on Jun 27, 2018) we will drop Py3.7 support on the next release. Dataclasses and the walrus operator will help with code cleanliness.
  • Deprecate optimal for dp or fix Is opt_einsum.paths.optimal algorithm correct? #167. I would note that the dp algorithm is pretty dense and not particularly readable.
  • Make a decision on global preprocessing in Perform some simple preprocessing of contractions #114.
  • The code base is grown fairly organically and is written in a Python 2 style, I would propose a general refactor for better readability and therefore extensibility.

@jcmgray Any features you would like to try and get in?

@jcmgray
Copy link
Collaborator

jcmgray commented Jul 5, 2022

The only possible small thing from my side I've just raised in (#193). The list of bigger things to consider for next release all look good too.

@dgasmith
Copy link
Owner Author

Nearly 2 (!) years later we should look into a 3.4 release after 4 (!!!) years after 2.3, especially for Py3.12 (#221). I'm a bit amazed that we appear to be stable and working for this duration without too many issues while maintaining 16M/month downloads.

I'm going to ask around and play with our typing a bit to make sure we do not make the situation worse with the current hints (although advantageous for internal dev). Anything else we should get in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants