Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with an error when there are no running domains and -c is used #26

Open
dguerri opened this issue Nov 13, 2015 · 1 comment
Open
Milestone

Comments

@dguerri
Copy link
Owner

dguerri commented Nov 13, 2015

See #24
In a next release we could think about introducing an additional flag for offline images backup. Having the backup performed always, regardless of the mode specified by the user, could be a bit confusing.
Alternatively we could just exit with an error if -c is used.

@dguerri dguerri added this to the 3.0 milestone Nov 13, 2015
@AJRepo
Copy link
Collaborator

AJRepo commented Nov 13, 2015

Sure. One question is what to do if someone specifies "-b /directory -c" To me -b indicates that a backup should be done to that directory. Right now, after Merge #25 , if someone specifies -c but not the -b flag on a shut-off domain (or one found from "all") then no backup of the shut-off domain is done, it skips it. We could just say "-b and -c flags can't both be specified at the same time but -b and -C can".

How about instead of an additional flag for offline backup, a "state" flag which indicates the state of the VMs to backup. The default could be "any" or running" If no running domains are found it could state that no running domains were found and suggest something like "try --state=any or --state=shut-off "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants