Issue #15 General Resusable Snackbar and Connection Utility for Slow or No Internet #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laavanye Bahl <laavanye.bahl@gmail.com>
…ewPager Signed-off-by: Laavanye Bahl <laavanye.bahl@gmail.com>
|
@laa-1-yay You shouldn't ping Google to check if the device has Internet access. You should let the app try to sync, and if it fails you should provide a callback method and notify the fragment that it hasn't Internet connection. |
|
@erlingfjelstad Thanks for the guidance. I've implemented the things you suggested and have submitted a pull request for the same : #35 |
|
@laa-1-yay Thank you. Closing this pull-request in favor of #35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue no #15