Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkCallBack Interface + General SnackBar Utility (Revised pr) #42

Closed
wants to merge 4 commits into from

Conversation

laavanyebahl
Copy link
Contributor

Issue no #15 Revised

API exception and type checked while syncing
Interface for NetworkCallBack
Callback implemented in DashboardViewPager
General Reusable SnackBar Utility

ff

Signed-off-by: Laavanye Bahl <laavanye.bahl@gmail.com>
Signed-off-by: Laavanye Bahl <laavanye.bahl@gmail.com>
Signed-off-by: Laavanye Bahl <laavanye.bahl@gmail.com>
Signed-off-by: Laavanye Bahl <laavanye.bahl@gmail.com>
@laavanyebahl
Copy link
Contributor Author

@arazabishov I've triggered the callback as soon as the exception is caught to avoid using the static handleAPIexception method.
setNetworkCallback() could've been added in NetworkUtils and callNetworkCallback() method could've been called by static handleAPIexception() method, but that would require a new instance of the class, leaving the interface uninitiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants