From db9ff836f991905f563e986ad23bb199bc912c7f Mon Sep 17 00:00:00 2001
From: Andrew Jones <ajones@digitalbazaar.com>
Date: Fri, 24 Nov 2023 14:19:15 +0000
Subject: [PATCH] Add initial validUntil and validFrom tests.

---
 test/10-verify.spec.js | 82 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)

diff --git a/test/10-verify.spec.js b/test/10-verify.spec.js
index 5ec0852c..35bf22dd 100644
--- a/test/10-verify.spec.js
+++ b/test/10-verify.spec.js
@@ -647,7 +647,89 @@ for(const [version, mockCredential] of versionedCredentials) {
             'The current date time (2022-06-30T19:21:25.000Z) is before the ' +
             '"issuanceDate" (2022-10-31T19:21:25.000Z).');
         });
+      }
+      if(version === 2.0) {
+        it('should reject if "now" is before "validFrom"', () => {
+          const credential = jsonld.clone(mockCredential);
+          credential.issuer = 'did:example:12345';
+          credential.validFrom = '2022-10-31T19:21:25Z';
+          const now = '2022-06-30T19:21:25Z';
+          let error;
+          try {
+            vc._checkCredential({credential, now});
+          } catch(e) {
+            error = e;
+          }
+          should.exist(error,
+            'Should throw error when "now" is before "validFrom"');
+          error.message.should.contain(
+            `The current date time (${now}) is before the ` +
+            `"validFrom" (${credential.validFrom}).`);
+        });
+        it('should reject if "now" is after "validUntil"', () => {
+          const credential = jsonld.clone(mockCredential);
+          credential.issuer = 'did:example:12345';
+          credential.validUntil = '2022-06-30T19:21:25Z';
+          const now = '2022-10-30T19:21:25Z';
+          let error;
+          try {
+            vc._checkCredential({credential, now});
+          } catch(e) {
+            error = e;
+          }
+          should.exist(error,
+            'Should throw error when "now" is after "validUntil"');
+          error.message.should.contain(
+            `The current date time (${now}) is after the ` +
+            `"validUntil" (${credential.validUntil}).`);
+        });
+        it('should accept "validFrom"', () => {
+          const credential = jsonld.clone(mockCredential);
+          credential.issuer = 'did:example:12345';
+          credential.validFrom = '2022-06-30T19:21:25Z';
+          const now = '2022-10-30T19:21:25Z';
+          let error;
+          try {
+            vc._checkCredential({credential, now});
+          } catch(e) {
+            error = e;
+          }
+          should.not.exist(error,
+            'Should not throw error when "validFrom" is valid');
+        });
+        it('should accept "validUntil"', () => {
+          const credential = jsonld.clone(mockCredential);
+          credential.issuer = 'did:example:12345';
+          credential.validUntil = '2025-10-31T19:21:25Z';
+          const now = '2022-06-30T19:21:25Z';
+          let error;
+          try {
+            vc._checkCredential({credential, now});
+          } catch(e) {
+            error = e;
+          }
+          should.not.exist(error,
+            'Should not throw error when "issuanceDate" is valid');
+        });
 
+        it('should accept both "validFrom" and "validUntil" are valid', () => {
+          const credential = jsonld.clone(mockCredential);
+          credential.issuer = 'did:example:12345';
+          credential.validFrom = '2022-05-30T19:21:25Z';
+          credential.validUntil = '2025-05-30T19:21:25Z';
+          const now = '2022-06-30T19:21:25Z';
+          let error;
+          try {
+            vc._checkCredential({credential, now});
+          } catch(e) {
+            error = e;
+          }
+          should.exist(error,
+            'Should throw error when "now" is before "issuanceDate"');
+          error.message.should.contain(
+            'The current date time (2022-06-30T19:21:25.000Z) is before the ' +
+            '"issuanceDate" (2022-10-31T19:21:25.000Z).');
+        });
       }
       it('should reject if "credentialSubject" is empty', () => {
         const credential = jsonld.clone(mockCredential);