Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support -html flag #69

Closed
mdb opened this issue Mar 1, 2024 · 1 comment
Closed

Support -html flag #69

mdb opened this issue Mar 1, 2024 · 1 comment

Comments

@mdb
Copy link
Contributor

mdb commented Mar 1, 2024

👋 It could be handy to support a -html flag for rendering the tf-summarize output as HTML.
@mdb mdb mentioned this issue Mar 1, 2024
Merged
dineshba pushed a commit that referenced this issue Mar 9, 2024
@mdb
support -html flag to render output as HTML (#70)
c447ded 
* support `-html` flag to render output as HTML

This addresses issue #69 to support HTML output.

This also...

- updates the README usage docs
- validates that multiple, conflicting format flags are not provided
- fixes a bug in the tests to properly validate expected tf-summarize errors

Signed-off-by: Mike Ball <mikedball@gmail.com>

* improve tests to exercise outputs

Previously, the tf-summarize tests did not exercise the tool's ability
to summarize plan outputs. This fixes that!

* ensure 'make help' outputs details on all targets

By adding a code comment in association with all Make targets, `make
help` now documents all targets:

```
$ make help
build                          build the binary
example                        generate example Terraform plan
help                           prints help (only for tasks with comment)
i                              build and install to /usr/local/bin/
install                        build and install to /usr/local/bin/
lint                           lint source code
test                           go test
```

* put HTML resources in <code> within summary

This makes the HTML output a bit more consistent with output elsewhere.

* protecting against stale tests runs

This protects against false positives running the tests.

---------

Signed-off-by: Mike Ball <mikedball@gmail.com>
@dineshba
Copy link
Owner

dineshba commented Mar 9, 2024

Closing with PR #70

@dineshba dineshba closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdb @dineshba