Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect LOC used in presence of multiple levels of indirection #6

Open
NHOrus opened this issue Mar 31, 2016 · 1 comment
Open

Incorrect LOC used in presence of multiple levels of indirection #6

NHOrus opened this issue Mar 31, 2016 · 1 comment

Comments

@NHOrus
Copy link

NHOrus commented Mar 31, 2016

Or depscheck report Lumberjack as a good candidate for removing from dependencies, when it isn't:

 - Package lumberjack (gopkg.in/natefinch/lumberjack.v2) is a good candidate for removing from dependencies.

   Only 0 LOC used, in 1 calls, with 0 level of nesting

Standard usage pattern of Lumberjack is, to quote readme,

log.SetOutput(&lumberjack.Logger{
    Filename:   "/var/log/myapp/foo.log",
    MaxSize:    500, // megabytes
    MaxBackups: 3,
    MaxAge:     28, //days
})

with log interacting with inner implementation of lumberjack.Logger as io.WriteCloser.
This is misleading, and may be a good candidate to improve code or add as example of false positive in Readme.

@divan
Copy link
Owner

divan commented Mar 31, 2016

Oh, nice example, thanks! I'll investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants