Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issue on Melange file aspect import #106

Open
eduardoafs opened this issue Feb 21, 2018 · 1 comment
Open

Small issue on Melange file aspect import #106

eduardoafs opened this issue Feb 21, 2018 · 1 comment

Comments

@eduardoafs
Copy link

Hi everyone,

I found a small issue, by accident, in the aspect import on .melange file. It is not a big deal but took me some time to find out what was going on, since the stacktrace was not helping.

If you have duplicated imports on the .melange file (i.e. import the same aspect two times) the generation of the adapters will fail. The stacktrace suggests something within the file lock, pointing that a file already exists, the generation is aborted.

Simple bug, simple fix, just check for duplicated entries before running the generator. Trigger a warning might be useful.

@dvojtise
Copy link
Contributor

dvojtise commented Mar 9, 2018

another approach that may help to avoid this issue is to use wildcard
If you import all aspects of a given package

simply do:

with org.company.mypackage.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants