Fix bugzilla 24845 - Compiler error when trying to assign to an AA va…

[dkorpel]

…lue of an enum instance

There used to be a special case that indexing an associative array literal results in an rvalue, but any other result of indexing an AA rvalue is still an lvalue. This PR gives AA's the same rules as static arrays: the indexed value is an lvalue iff the array is an lvalue. This is different from dynamic arrays, where &[x][0] is allowed.

Targeting master because this could break code that relied on makeAA()["key"] = 0 compiling.

[dlang-bot]

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	24845	major	Compiler error when trying to assign to an AA value of an enum instance

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17094"

[thewilsonator]

This is severity major: should it go to stable?

[dkorpel]

See opening comment

Targeting master because this could break code that relied on makeAA()["key"] = 0 compiling.