Skip to content

Commit

Permalink
Fix Issue 22212 - dmd version has -dirty suffix on windows
Browse files Browse the repository at this point in the history
Typically, git-clone probes the filesystem to see if it handles the executable bit correctly and the `core.fileMode` variable is automatically set as necessary. However when building dmd releases using vagrant box method, git-clone is done on a Linux host (i.e a filesystem that handles the filemode correctly), then scp'd to a Windows VM (i.e an environment that loses the filemode). So when building Windows binaries, always ensure this variable is set to `false`.
  • Loading branch information
ibuclaw committed Dec 27, 2023
1 parent 11648ff commit efe3deb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions create_dmd_release/create_dmd_release.d
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,20 @@ void cleanAll(string branch)
changeDir(cloneDir~"/dmd");
run("git clean -f -x -d"); // remove all untracked/ignored files
run("git checkout ."); // undo local changes, e.g. VERSION
version (Windows)
run("git config core.fileMode false"); // ignore executable bit of files

info("Cleaning Phobos");
changeDir(cloneDir~"/phobos");
run("git clean -f -x -d");
version (Windows)
run("git config core.fileMode false");

info("Cleaning Tools");
changeDir(cloneDir~"/tools");
run("git clean -f -x -d");
version (Windows)
run("git config core.fileMode false");
}

void buildAll(string branch)
Expand Down

0 comments on commit efe3deb

Please sign in to comment.