Merge stable #567
Merged
Merge stable #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibuclaw
commented
Jan 1, 2024
•
ibuclaw
commented
- Fix Issue 22212 - dmd version has -dirty suffix on windows
Typically, git-clone probes the filesystem to see if it handles the executable bit correctly and the `core.fileMode` variable is automatically set as necessary. However when building dmd releases using vagrant box method, git-clone is done on a Linux host (i.e a filesystem that handles the filemode correctly), then scp'd to a Windows VM (i.e an environment that loses the filemode). So when building Windows binaries, always ensure this variable is set to `false`.
|
Thanks for your pull request, @ibuclaw! Bugzilla references
|
thewilsonator
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.