Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use an absolute path in the activate script. #569

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

JohanEngelen
Copy link
Contributor

This fixes the activate script when install.sh is called with a relative path (e.g. install.sh -p .).

This fixes the activate script when install.sh is called with a relative path (e.g. `install.sh -p .`).
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@JohanEngelen
Copy link
Contributor Author

CI failures are not related to this change.

@thewilsonator thewilsonator merged commit 624af72 into dlang:master Jan 28, 2024
15 of 18 checks passed
@JohanEngelen JohanEngelen deleted the abspath branch January 28, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants