Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS has updated itself AGAIN #287

Open
TurkeyMan opened this issue Dec 7, 2024 · 9 comments
Open

VS has updated itself AGAIN #287

TurkeyMan opened this issue Dec 7, 2024 · 9 comments

Comments

@TurkeyMan
Copy link

Doesn't work with VS latest again :(

@rainers
Copy link
Member

rainers commented Dec 7, 2024

Are you running on VS Preview now, i.e. 17.13 ATM? 17.12 should work with Visual D 1.4.0-rc3.

I recently updated to VS 17.13 myself and updated the dbuild.dll dependency. I'm preparing rc4 which should support that, too.

@TurkeyMan
Copy link
Author

My colleague reported again; he had to update his VS install to achieve compatibility with some other SDK he needed.
It seems MS are updating VS every couple of months these days. Seems like a terrible decision; really bad for plugin authors!

@rainers
Copy link
Member

rainers commented Dec 14, 2024

Sorry for the delay, I ran into some difficulties building on a new computer and then got distracted. VS 17.13 support is now released in https://github.com/dlang/visuald/releases/tag/v1.4.0-rc4

@TurkeyMan
Copy link
Author

TurkeyMan commented Jan 3, 2025

I just installed VS Community now on a new laptop. Still failing out-of-the-box with all latest stuff.

  • I used 1.4.0-rc4
    image
1>C:\Program Files (x86)\VisualD\msbuild\dcompile.targets(193,5): error MSB4062: The "dbuild.CompileD" task could not be loaded from the assembly C:\Program Files (x86)\VisualD\msbuild\dbuild.Current.dll. Could not load file or assembly 'file:///C:\Program Files (x86)\VisualD\msbuild\dbuild.Current.dll' or one of its dependencies. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

Seems the installer installed 17.12.3; not 17.12.13? I didn't change any options, that was default install; although I think I did see an option to install 17.12.13 unchecked by default (it described it as 'beta', and I thought that VD wouldn't work with a beta release for sure, so I did not check it :P)

This seems to be an ongoing battle... I don't understand what MS think they're doing to have created this situation, but I wonder if there is some way that VD could self-resolve, by auto-updating or something in the case of detected version mismatch?

@TurkeyMan
Copy link
Author

I upgraded to the 17.13 preview, since it looks like you implemented support for 17.13, but when I try and build, instead of getting a build error, it just does nothing:

Rebuild started at 11:13 AM...
1>------ Rebuild All started: Project: sampledb, Configuration: Debug x64 ------
========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ==========
========== Rebuild completed at 11:13 AM and took 02.614 seconds ==========

That's a rebuild-all; it didn't build anything from the project, but it says it's complete.

I checked the version:
image

It says 17.13, but there's no VD plugins shown in the list...
I re-ran the VD 1.4.0-rc4 installer, but it didn't seem to do anything.

@rainers
Copy link
Member

rainers commented Jan 3, 2025

Seems the installer installed 17.12.3; not 17.12.13? I

17.12.3 is the latest release of the 17.12 series, see https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes

I skipped that version on my system, so I botched the check in "c:\Program Files (x86)\VisualD\msbuild\dcompile_defaults.props" in line 50, it should read ``< 13` instead of 12.

This seems to be an ongoing battle...

I think MS is only partly to blame. We are hooking into the VC build tasks in a probably unexpected way. There is a DLL that we could link against, though (Microsoft.Build.CPPTasks.Common.Base.dll), but msbuild cannot load it at the same time as the versioned one. The latter one is necessary to build C/C++ files.

@rainers
Copy link
Member

rainers commented Jan 3, 2025

It says 17.13, but there's no VD plugins shown in the list... I re-ran the VD 1.4.0-rc4 installer, but it didn't seem to do anything.

Did you install the preview side-by-side with the community version? The installer doesn't detect multiple installations of VS 2022, see also #271. I suspect without the importbefore/importafter files the unknown xml-entries in the project file just get ignored by msbuild.

@TurkeyMan
Copy link
Author

Ah, I did indeed install it beside the community version... It didn't offer to replace it or uninstall, installing it beside the existing version was the default option.

@rainers
Copy link
Member

rainers commented Jan 3, 2025

I have fixed the VS 17.12 version check and added support to install for 2 parallel installations of VS 2022 (will add a few more later). Please try https://github.com/dlang/visuald/releases/tag/v1.4.0-rc5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants