Error compiling

[Filco306]

Hello!

Thank you for a very nice project. I am trying to install it inside a docker image and have downloaded everything, but I am getting the following error:

I have no name!@c7cd63e260b5:/workspace/src/minicore$ make
g++ -DBLAZE_USE_SLEEF=1 -O3 -std=gnu++17 -march=native -Wall -Wextra -Wpointer-arith -Wformat -Wunused-variable -Wno-attributes -Wno-ignored-qualifiers -Wno-unused-function -Wdeprecated -Wno-deprecated-declarations -Wno-deprecated-copy  -I. -Iinclude -Iinclude/minicore -Iblaze -Ilibosmium/include -Iprotozero/include -Ipdqsort -Iinclude/thirdparty -Isleef/build/include -Isleef/dynbuild/include   -DBOOST_NO_AUTO_PTR -lz   -L./libkl -Lsleef/build/lib -Lsleef/dynbuild/lib -Llibkl -Llibsimdsampling -lz src/utils/alphaest.cpp -o alphaest -DNDEBUG -fopenmp -O3 libsleef.a
In file included from include/minicore/util/shared.h:2,
                 from include/minicore/utility.h:6,
                 from src/utils/alphaest.cpp:1:
./robin-hood-hashing/src/include/robin_hood.h: In member function ‘size_t robin_hood::detail::Table<IsFlat, MaxLoadFactor100, Key, T, Hash, KeyEqual>::calcMaxNumElementsAllowed(size_t) const’:
./robin-hood-hashing/src/include/robin_hood.h:1849:52: error: ‘numeric_limits’ is not a member of ‘std’
 1849 |         if (ROBIN_HOOD_LIKELY(maxElements <= (std::numeric_limits<size_t>::max)() / 100)) {
      |                                                    ^~~~~~~~~~~~~~
./robin-hood-hashing/src/include/robin_hood.h:174:59: note: in definition of macro ‘ROBIN_HOOD_LIKELY’
  174 | #    define ROBIN_HOOD_LIKELY(condition) __builtin_expect(condition, 1)
      |                                                           ^~~~~~~~~
./robin-hood-hashing/src/include/robin_hood.h:1849:73: error: expected primary-expression before ‘>’ token
 1849 |         if (ROBIN_HOOD_LIKELY(maxElements <= (std::numeric_limits<size_t>::max)() / 100)) {
      |                                                                         ^
./robin-hood-hashing/src/include/robin_hood.h:174:59: note: in definition of macro ‘ROBIN_HOOD_LIKELY’
  174 | #    define ROBIN_HOOD_LIKELY(condition) __builtin_expect(condition, 1)
      |                                                           ^~~~~~~~~
./robin-hood-hashing/src/include/robin_hood.h:1849:76: error: ‘::max’ has not been declared; did you mean ‘std::max’?
 1849 |         if (ROBIN_HOOD_LIKELY(maxElements <= (std::numeric_limits<size_t>::max)() / 100)) {
      |                                                                            ^~~
./robin-hood-hashing/src/include/robin_hood.h:174:59: note: in definition of macro ‘ROBIN_HOOD_LIKELY’
  174 | #    define ROBIN_HOOD_LIKELY(condition) __builtin_expect(condition, 1)
      |                                                           ^~~~~~~~~
In file included from /usr/include/c++/11/algorithm:62,
                 from ./robin-hood-hashing/src/include/robin_hood.h:42,
                 from include/minicore/util/shared.h:2,
                 from include/minicore/utility.h:6,
                 from src/utils/alphaest.cpp:1:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
make: *** [Makefile:145: alphaest] Error 1

What can I do about this? I am not very good at C++, so the error is probably something simple from my side.

Thank you in advance!

[dnbaker]

Hi -

Sorry for the trouble! I'm hoping this was just the library getting out of date.

I've just updated the main branch (#64) to try to fix this issue. Could you try it again?

Best,

Daniel