Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dobi cache does not appear to save very much time #229

Open
aidan-mundy opened this issue Nov 3, 2021 · 1 comment
Open

Dobi cache does not appear to save very much time #229

aidan-mundy opened this issue Nov 3, 2021 · 1 comment

Comments

@aidan-mundy
Copy link
Contributor

The dobi cache was created back when docker loaded the entire build context before building the image. Build context loading and caching is now scoped only to files used in the ADD/COPY commands, so is now much quicker. The upgrades to docker seem to have made dobi's cache obsolete. Additionally, docker images that ADD files from remote sources appear to be handled incorrectly by dobi. The remote file should be downloaded and checked for caching purposes before assuming the image is fully cached. This is handled by docker automatically.

Does it make sense for the dobi cache to remain a feature as it currently appears today?

@dnephin
Copy link
Owner

dnephin commented Nov 6, 2021

I think given the improvements to docker build it does make sense to remove the dobi cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants