Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slice() method should return a Collection instead of an array #195

Open
jwage opened this issue Apr 29, 2019 · 1 comment
Open

slice() method should return a Collection instead of an array #195

jwage opened this issue Apr 29, 2019 · 1 comment
Labels
BC break Enhancement

Comments

@jwage
Copy link
Member

jwage commented Apr 29, 2019

See question here where this was originally requested #125 (comment)
@jwage jwage added the BC break label Apr 29, 2019
@jwage jwage added this to the 2.0.0 milestone Apr 29, 2019
@jwage jwage mentioned this issue Apr 30, 2019
Closed
LIQRGV added a commit to LIQRGV/collections that referenced this issue Jan 14, 2021
@LIQRGV
Change Collection#slice return type to Collection
a0c0960 
This commit should resolve doctrine#195
@LIQRGV LIQRGV mentioned this issue Jan 14, 2021
Closed
LIQRGV added a commit to LIQRGV/collections that referenced this issue Jan 14, 2021
@LIQRGV
Change Collection#slice return type to Collection
cf1b49f 
This commit should resolve doctrine#195
@greg0ire
Copy link
Member

There is no clear upgrade path for this, I'm removing it from the 2.0.0 milestone as I don't see it getting done anytime soon.

@greg0ire greg0ire removed this from the 2.0.0 milestone Aug 24, 2022
@VincentLanglet VincentLanglet mentioned this issue Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Collection::slice() method to return an instance of Collection jwage/collections
2 participants
@jwage @greg0ire