Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if removal of MethodByName() call can improve dead code elimination. #368

Open
jmalloc opened this issue Oct 14, 2024 · 0 comments
Open

Comments

@jmalloc
Copy link
Member

jmalloc commented Oct 14, 2024

See golang/protobuf#1561

We use it here:

rm, ok := rt.MethodByName(m)

It may not matter much since this code would generally only be used from test packages, but it'd be good to confirm that they are still eliminated properly. It's also not that uncommon to have some tests in the non-test package to test unexported functions, though this should be rare with Dogma applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant