We value contributions and encourage everybody to contribute to the repository. This should be as easy as possible for you but there are a few things to consider when contributing. The following guidelines for contribution should be followed if you want to submit a pull request.
- You need a GitHub account
- Submit an issue ticket for your issue if there is no one yet.
- Describe the issue and include steps to reproduce if it's a bug.
- Ensure to mention the earliest version that you know is affected.
- If you are able and want to fix this, fork the repository on GitHub
-
In your forked repository, create a topic branch for your upcoming patch. (e.g.
feature--autoplayorbugfix--ios-crash)- Usually this is based on the master branch.
- Create a branch based on master;
git branch fix/master/my_contribution masterthen checkout the new branch withgit checkout fix/master/my_contribution. Please avoid working directly on themasterbranch.
-
Make sure you stick to the coding style that is used already.
-
Make use of the
.editorconfig-file if provided with the repository. -
Make commits of logical units and describe them properly.
-
Check for unnecessary whitespace with
git diff --checkbefore committing. -
If possible, submit tests to your patch / new feature so it can be tested easily.
-
Assure nothing is broken by running all the tests.
- Push your changes to a topic branch in your fork of the repository.
- Open a pull request to the original repository and choose the right original branch you want to patch.
Advanced users may install the
hubgem and use thehub pull-requestcommand. - If not done in commit messages (which you really should do) please reference and update your issue with the code changes. But please do not close the issue yourself. Notice: You can turn your previously filed issues into a pull-request here.
- Even if you have write access to the repository, do not directly push or merge pull-requests. Let another team member review your pull request and approve.