Update test for IPA clone #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see there are some comments in the companion IPA issue, so I will defer reviewing until you have had a chance to read that. |
The test for IPA clone has been modified to change the renewal master and CRL master and also check both IPA and PKI configs in primary and secondary servers. There are some known issues: https://pagure.io/freeipa/issue/9432
|
I've updated the test based on the info from the IPA ticket, but there are some remaining issues. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@fmarco76 Thanks! @ckelleyRH I have not seen new comments in the IPA ticket, and I don't think the remaining issues can be solved quickly anyway, can we merge this PR? |
|
@ckelleyRH Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for IPA clone has been modified to change the renewal master and CRL master and also check both IPA and PKI configs in primary and secondary servers.
There are some known issues:
https://pagure.io/freeipa/issue/9432