Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cms.password.skipLdapConnTest default value #4570

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Sep 20, 2023

Previously each PKI subsystem would check the DS connection on startup and fail to start if the DS is not available. To improve PKI service reliability the subsystem needs to start regardless of DS availability (since the subsystem can reconnect to the DS later when needed), so the cms.password.skipLdapConnTest param has been modified to be true by default such that it no longer checks the DS connection on startup.

The DS connection test has been updated to remove the command that configures the param since it's no longer needed.

Previously each PKI subsystem would check the DS connection on
startup and fail to start if the DS is not available. To improve
PKI service reliability the subsystem needs to start regardless
of DS availability (since the subsystem can reconnect to the DS
later when needed), so the cms.password.skipLdapConnTest param
has been modified to be true by default such that it no longer
checks the DS connection on startup.

The DS connection test has been updated to remove the command
that configures the param since it's no longer needed.
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@ckelleyRH ckelleyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Sep 20, 2023

@ckelleyRH @fmarco76 Thanks!

@edewata edewata merged commit c8fd8aa into dogtagpki:master Sep 20, 2023
149 of 151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants