Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make test badges linkable to actual tests #4582

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

MindTooth
Copy link
Contributor

Noticed they were not linked when I wanted to check the test for IPA which is not broken. Also, sorted them alphabetically.

@edewata
Copy link
Contributor

edewata commented Oct 6, 2023

Thanks for the PR! The links look good, but I'd prefer to keep them in the original order since it represents the installation order and priorities, i.e. CA must be installed first, so it's important that it works. Do you mind revising the PR?

@MindTooth MindTooth force-pushed the chore/make_tests_badged_linked branch from d25a0fb to a291752 Compare October 6, 2023 19:20
@MindTooth
Copy link
Contributor Author

Fixed. Seems that I also caught a "bug". 😛

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@edewata edewata merged commit 5a2feb7 into dogtagpki:master Oct 6, 2023
151 of 152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants