Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch v11.5] Include -a when calling certutil to verify a certificate exists #4783

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

rcritten
Copy link
Contributor

Without the -a certutil pauses just prior to displaying the trust flags. This is strange because the flags are stored in the internal token which is what is being queried. Only the internal token password is made available to certutil.

The call looks like this in an IPA installation:

certutil -L -d /etc/pki/pki-tomcat/alias -h internal \ -f/etc/pki/pki-tomcat/pfile -n 'Directory Server CA certificate'

In any case adding -a skips this trust value and displays the cert as a PEM and doesn't require the password.

Fixes: #4782

Without the -a certutil pauses just prior to displaying the
trust flags. This is strange because the flags are stored in the
internal token which is what is being queried. Only the internal
token password is made available to certutil.

The call looks like this in an IPA installation:

certutil -L -d /etc/pki/pki-tomcat/alias -h internal \
-f/etc/pki/pki-tomcat/pfile -n 'Directory Server CA certificate'

In any case adding -a skips this trust value and displays the
cert as a PEM and doesn't require the password.

Fixes: dogtagpki#4782

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

This code has been that way for a long time, so I suppose something changed recently in NSS or some other packages triggering this new behavior. Do you think that's a bug, or is that the proper behavior?

Looks like this code doesn't exist anymore in the master branch so there's no need cherry-pick this patch.

@edewata edewata merged commit d6cf80b into dogtagpki:v11.5 Jun 18, 2024
120 of 130 checks passed
@rcritten
Copy link
Contributor Author

LGTM. Thanks!

This code has been that way for a long time, so I suppose something changed recently in NSS or some other packages triggering this new behavior. Do you think that's a bug, or is that the proper behavior?

Looks like this code doesn't exist anymore in the master branch so there's no need cherry-pick this patch.

I don't recall seeing this during development of HSM in IPA but there are several permutations when installing the KRA. It's possible I overlooked this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants