-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PATCH for dstore/Rest #161
Comments
It would probably be better to support this as a different store than dstore/Rest. While there is no standard for RESTful services, the PATCH verb is not as widely supported and even when it is, the way it is used is often against the intent of the RFC. |
Either way, it would kind of suggest a new API for dstore too, right? (Or an additional option to It's certainly something that's crossed my mind before (along with the fact that dstore and dgrid don't really accommodate partial item updates/re-renders currently). |
I could see a situation where the consumer of the store wouldn't need/want to care how the data was persisted. My thought is that the API would remain the same for the store, but the implementation would determine if it could provide the description of the changes to the PATCH verb versus PUT. The store should do the "diff", not the consumer. No matter what, it is not a straight forward enhancement. Though it touches on the whole store API and the ability to notify consumers of "changes" only, so they can only invalidate and redraw certain parts of their display. |
I suppose that's a point (that the consumer doesn't need to care), but in some cases the consumer already knows the diff (e.g. |
I am using a dStore/Rest-backed dGrid. When editing just one value in a row, it would be much more efficient and also safer if the store could make a PATCH request rather than a PUT request that contains the entire row.
The text was updated successfully, but these errors were encountered: