Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli webp conversion results with an error #744

Closed
bpedazur opened this issue Dec 8, 2022 · 6 comments
Closed

cli webp conversion results with an error #744

bpedazur opened this issue Dec 8, 2022 · 6 comments
Labels
bug Something isn't working package:cli

Comments

@bpedazur
Copy link

bpedazur commented Dec 8, 2022

Describe the bug
When I run the cli function for webp I get the fllowing error:
Aborted()
error: Aborted(). Build with -sASSERTIONS for more info.

To Reproduce
Steps to reproduce the behavior:

  1. run gltf-transform webp <input> <output>

Versions:

  • Version: running version 2.4.7 of glTF-Transform
  • Environment: Ubuntu 22, Node version v16.18.1
@donmccurdy
Copy link
Owner

@bpedazur could you give this a try on your OS?

npm install --global @gltf-transform/cli@next

It's a prerelease for v3 (with #752), including sharp instead of squoosh.

@donmccurdy donmccurdy added this to the v3.0 milestone Dec 21, 2022
@bpedazur
Copy link
Author

Hi. I tried it and unfortunately, it didn't work. I'm still getting the same issue. I tested it on my Ubuntu 22 machine and my Windows machine running the same node version - both resulted in the same error.

@donmccurdy
Copy link
Owner

Hm, I'm not sure what to make of that. Do other operations work, like gltf-transform --help? Does the model have any extensions, like Draco, that might be relying on WASM decoders? I'm assuming the vague Build with -sASSERTIONS message means something is failing in a WASM or native dependency...

@bpedazur
Copy link
Author

Other operations work fine. I noticed that it happens only with larger files (>200M), regardless of the extensions -some were Draco compressed and some were not.

@donmccurdy
Copy link
Owner

I see, thanks - can you share an example file? I suspect this might have something to do with node.js memory limits. Draco-compressed geometry is decompressed in memory, and textures must also be decompressed during the webp conversion, so it'll be easy to use a lot of memory quickly with files that are already large.

I suspect that limiting concurrency during compression might help here, but without a way to reproduce the error myself I probably cannot work on that fix.

@donmccurdy donmccurdy modified the milestones: v3.0, Backlog Jan 11, 2023
@donmccurdy donmccurdy closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2023
@donmccurdy
Copy link
Owner

Closing for now, as I'll need a way to reproduce the issue in order to work on this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:cli
Projects
None yet
Development

No branches or pull requests

2 participants