-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement #valid_doorkeeper_token? to support #doorkeeper_authorize! #37
Comments
Hi @cmitz . I'm not sure I understood your problem Doorkeeper::JWT generates a JWT token that is stored then in the database. So I don't sure which issue you're describing. Maybe you could prepare a RSpec example to show it? Thanks! |
I encountered this in a hobby application that I threw away when I finished playing with it, so I can't reproduce it very easily. I recall getting an error that I will try to find some time in the coming days to try and come up with an rspec example. |
This is super strange just because |
In a doorkeeper-protected application, a controller could look like this:
However, when using Doorkeeper::JWT to generate access tokens this commonly used pattern breaks since a Doorkeeper::JWT token is just a string...
The
before_action :doorkeeper_authorize!
way of authenticating calls breaks here, because it expects adoorkeeper_token
to implement theacceptable?
method:https://github.com/doorkeeper-gem/doorkeeper/blob/4dc432c74a424c85e141b131939faafa98a916fc/lib/doorkeeper/rails/helpers.rb#L16
I have only just started my sideproject and Doorkeeper is relatively new to me, but would it work if
Doorkeeper::JWT
tokens extend the token mixin?https://github.com/doorkeeper-gem/doorkeeper/blob/v5.2.1/lib/doorkeeper/models/access_token_mixin.rb#L275
The text was updated successfully, but these errors were encountered: