-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a dora-timer
tool nodes
#488
Comments
Providing the ticks directly by dora has some advantages:
Also, we will probably need some sort of "special dora-provided inputs" in the future for features such as deadlines. I think that a special (As a side node, maybe the input name 'timer' doesn't make it clear enough that it results in a regular tick, not just a single event. Maybe a name like "interval" would make this clearer.) |
We currrently have a very bespoke implementation of a timer within dora, that is if we see
dora/timer/secs/1
, we spawn a timer node inside of the graph.The thing is that this pattern is not really explicit and we should probably rewrite this piece to have an explicit node that is spawned in a way that is clear for the users. We would be able to also make it more configurable such as adding a maximum duration of ticking.
This would also make it more explicit if there is multiple machine as each machine would not tick at the same time.
This would also reduce the complexity of the deserialization of our dataflow.
The text was updated successfully, but these errors were encountered: