Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action Support #90

Open
jashanbhullar opened this issue Nov 1, 2022 · 3 comments
Open

Add Github Action Support #90

jashanbhullar opened this issue Nov 1, 2022 · 3 comments

Comments

@jashanbhullar
Copy link

This tool can be easily packaged and deployed as GitHub action when doing code reviews.
I think all that's required is to

  • add documentation
  • deploy on GitHub action marketplace

Willing to help on this.

@dosisod
Copy link
Owner

dosisod commented Nov 4, 2022

Sorry for the delay on this! Yes, I think all you have to do is specify an action.yaml file (according to the docs) and we should be good to go.

I would be inclined to put this action into a seperate repository though, say dosisod/refurb-action, that way we can deploy and test the action independently from Refurb. If you want you could create your own repo to test how this might look, and when it is ready to go, I can create the new repo and copy everything over (or find some other way to get uploaded).

Thank you for taking the initiative to work on this! I think that having more ways for people to use Refurb will be greatly beneficial for all.

@justinchuby
Copy link

justinchuby commented Jan 23, 2023

We recently added refurb to the list of lintrunner adapters justinchuby/lintrunner-adapters#35, which supports displaying GitHub code scanning messages - it can be an easy option if you didn’t want to create your own action.

@dosisod
Copy link
Owner

dosisod commented Mar 7, 2023

Just an update, I added support for Github Annotations in #226. Basically, you can now use the --format github flag to output diagnostic info which Github can use to add nice inline error messages (example here).

I plan on adding an actual Github Action which wraps this, and I should have it done by this time next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants