-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout failure: "Git fetch failed with exit code 128" #9009
Comments
So this is... interesting. I agree this seems like essentially a random network failure that is not the fault of the code. Also... it doesn't seem like there is anything to be done other than retry the build. @ulisesh and @AlitzelMendez. This seems like another instance of a "known issue" that would really benefit from the ability to get retried automatically. I think Carlos did the right thing by opening the known issue, but his PR (and any future PR that hits this) is still going to be blocked, since the build doesn't run at all in this case, because the checkout failed. And it would be great to help folks that hit this. |
I created the issue to track how often it was happening and measure the impact of the problem. It might be hard to get traction on networking problems but having the number of impacted builds has great value in my opinion. In the last 24 hours, we had 37 builds failed with the same error. cc @markwilkie who might find this data interesting. I think automatic retries for known issues will be the next feature after we are done with analyzing builds retroactively, we can discuss this if people think we should change priorities. |
So 37 builds were caught with the known issues feature @ulisesh ? Could I get the query please? (super exciting) |
I saw 37 hits in the office but now I only see 33 🤔. There are 33 failed jobs in 2 different builds. Sorry if I misused the terms but I still think it is great that we can track these build breaks 😄 This is the query: KnownIssues |
This happened 36 times in the last 24 hours. Should we add a retry (assuming that's possible)? |
GitHub reported degraded git operations yesterday: https://www.githubstatus.com/incidents/00km0kwpz23b |
This issue may have started in early 2022 but seems to remain w/ 29 matching failures in the last 24 hours. https://www.githubstatus.com/ and various Azure / Azure DevOps status pages aren't showing any current or recent degradations. Unclear what's going on this time beyond what appears to be DNS flakiness. I looked at the last 7 reports; all but one showed Without more information, I think the best we could do is auto retry when the problem occurs. @AlitzelMendez and @carlossanlop what are your thoughts on including |
It's fine, we can try that, as long as we monitor it closely, because if we keep seeing the failure even with a retry, I think we should just go back to |
you mean |
I do not know if it was tried in the past. |
sounds like a good plan @dougbu, let's try |
updated the description to try retries |
query:
I will check this on Monday to see how it is going, posting here the query so I don't loose it :) |
the success rate (having a green build) after the retry was between 30% to 50% per day, so this doesn't solve the issue, it just helps to mitigate it a little bit. |
Build
https://dev.azure.com/dnceng/public/_build/results?buildId=1706886&view=results
Build leg reported
Libraries Test Run release coreclr Linux_musl x64 Release
Pull Request
Rolling build for runtime
Action required for the engineering services team
To triage this issue (First Responder / @dotnet/dnceng):
If this is an issue that is causing build breaks across multiple builds and would get benefit from being listed on the build analysis check, follow the next steps:
Additional information about the issue reported
The
Checkout dotnet/runtime@main to s
step is the one that failed. Here is the end of the log output:Report
Summary
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=323960
Error message validated:
Git fetch failed with exit code: 128
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/28/2023 9:15:14 PM UTC
The text was updated successfully, but these errors were encountered: