Redundant Equality CodeFix for "... == false"

[awaescher]

Visual Studio has a built-in CodeFix for "Redundant Equality" already but only if the comparison is done against True

I would really love to have a CodeFix to convert ... = False to Not ....

While I know comparing against False is not wrong technically, I think it's pretty old fashioned to use.

C#

HttpResponseMessage response;

// bad
if (response.IsSuccessStatusCode == false)
    throw ...;

// good
if (!response.IsSuccessStatusCode)
    throw ...;

VB.NET

Dim response As HttpResponseMessage

' bad
If response.IsSuccessStatusCode = False Then
    Throw ...
End If

' good
If Not response.IsSuccessStatusCode Then
    Throw ...
End If

[josefpihrt]

Hi, this analyzer is already part of Roslynator: https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md

[awaescher]

Whoa, how did I miss that? I tried to get a CodeFix in Visual Studio quite a few times now.
Sorry for burning your valuable time.

As I am looking to use this on a huge VB code base ... could it be that is for C# only?

[josefpihrt]

Unfortunately yes, almost all Roslynator analyzers are for C# only.

[awaescher]

Yeah, that's what I thought. Totally understandable but a pity for people maintaining legacy VB code 😉
Nevermind, I am really grateful for the work you are doing, Roslynator is a great extension. Thank you!