Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Add minimal testing to MsQuic CI #101589

Closed
CarnaViire opened this issue Nov 22, 2023 · 4 comments · Fixed by microsoft/msquic#4466
Closed

[QUIC] Add minimal testing to MsQuic CI #101589

CarnaViire opened this issue Nov 22, 2023 · 4 comments · Fixed by microsoft/msquic#4466
Assignees
Milestone

Comments

@CarnaViire
Copy link
Member

CarnaViire commented Nov 22, 2023

Add minimal tests on all the same platforms that runtime CI uses.
This is needed to verify that the produced library is loadable and to prevent regressions like Alpine Arm32 #91757

By minimal test I mean a .NET application that would at least check QuicConnection.IsSupported, and it might also have a minimal send-receive test. This obviously can be expanded if we ever feel the need to.

We don't need a rolling build, I assume this might be only needed if we update MsQuic - so the testing leg only needs a manual trigger, if it is easier to do so.

@ManickaP ManickaP transferred this issue from dotnet/msquic Apr 26, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 26, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 26, 2024
@ManickaP ManickaP changed the title Add minimal testing to CI [QUIC] Add minimal testing to MsQuic CI Apr 26, 2024
@ManickaP ManickaP added area-System.Net.Quic and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners untriaged New issue has not been triaged by the area owner labels Apr 26, 2024
@ManickaP ManickaP added this to the Future milestone Apr 26, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@CarnaViire
Copy link
Member Author

CarnaViire commented May 16, 2024

Another type of regression, added functionality broke Linux distros beside Ubuntu: #101625 (microsoft/msquic#3849, microsoft/msquic#4264)

Related: microsoft/msquic#3460

@liveans liveans self-assigned this Aug 6, 2024
@liveans
Copy link
Member

liveans commented Aug 15, 2024

Initial implementation is here: liveans/play-with-docker-github-actions
Next step: Integrate it into msquic PR pipeline

@liveans
Copy link
Member

liveans commented Aug 26, 2024

I think we can close this now, since we have some basic test on msquic pipeline.

@liveans liveans closed this as completed Sep 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants