Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review contatenation logic in the Wasm SDK #103783

Open
javiercn opened this issue Jun 20, 2024 · 4 comments
Open

Review contatenation logic in the Wasm SDK #103783

javiercn opened this issue Jun 20, 2024 · 4 comments
Assignees
@maraf
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Milestone
10.0.0

Comments

@javiercn
Copy link
Member 

          There are several more similar concatenations with `$(PublishDir)` and `$(OutDir)`. Do we need to address those as well?

Originally posted by @maraf in #103768 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 20, 2024
@javiercn javiercn mentioned this issue Jun 20, 2024
Merged
@am11 am11 added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 20, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@maraf maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm area-Build-mono and removed area-Infrastructure-mono labels Jun 21, 2024
@maraf maraf added this to the 9.0.0 milestone Jun 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2024
@maraf maraf self-assigned this Jun 21, 2024
@maraf
Copy link
Member

maraf commented Aug 13, 2024

Moving to 10 as the remaining places don't block anything now

@maraf maraf modified the milestones: 9.0.0, 10.0.0 Aug 13, 2024
@pavelsavara
Copy link
Member

is this dupe ? #99292

@maraf
Copy link
Member

maraf commented Dec 12, 2024

is this dupe ? #99292

No. This one is about how we concatenate paths in MSBuild. The other one is about what is printed to the console after successful publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
4 participants
@pavelsavara @am11 @javiercn @maraf