Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert failure in GC/API/NoGCRegion/Callback_Svr test #86612

Closed
elinor-fung opened this issue May 22, 2023 · 9 comments
Closed

Assert failure in GC/API/NoGCRegion/Callback_Svr test #86612

elinor-fung opened this issue May 22, 2023 · 9 comments
Labels
area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab

Comments

@elinor-fung
Copy link
Member

elinor-fung commented May 22, 2023

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=282177
Build error leg or test failing: GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
Pull request: #86598

GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh [FAIL]
      
  Assert failure(PID 85618 [0x00014e72], Thread: 3483931 [0x35291b]): !gradual_decommit_in_progress_p || (seg != ephemeral_heap_segment) || (heap_segment_committed (seg) <= heap_segment_decommit_target (seg))
      File: /Users/runner/work/1/s/src/coreclr/gc/gc.cpp Line: 14989
      Image: /private/tmp/helix/working/AE9E0917/p/corerun

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "!gradual_decommit_in_progress_p || (seg != ephemeral_heap_segment) || (heap_segment_committed (seg) <= heap_segment_decommit_target (seg))",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Build Definition Test Pull Request
290202 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289722 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86892
289670 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86494
289543 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289555 dotnet/runtime PayloadGroup0.WorkItemExecution #86883
289508 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86886
289469 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289467 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289458 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86883
289438 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289426 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86877
289422 dotnet/runtime PayloadGroup0.WorkItemExecution #86875
289391 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289311 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85317
289291 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289251 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
289191 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85317
288931 dotnet/runtime PayloadGroup0.WorkItemExecution #86698
288790 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86855
288702 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288668 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288645 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288617 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85317
288575 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86391
288474 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86842
288494 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288447 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288441 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288436 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85558
288414 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86841
288359 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288372 dotnet/runtime PayloadGroup0.WorkItemExecution #86839
288334 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288286 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86835
288255 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86494
288250 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86698
288193 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288162 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288148 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288122 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
288063 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86822
287982 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86813
287876 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86530
287608 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86803
287084 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
287029 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #81632
287003 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85558
286958 dotnet/runtime PayloadGroup0.WorkItemExecution #86482
286903 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
286827 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
286848 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
286834 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86782
286820 dotnet/runtime PayloadGroup0.WorkItemExecution #86747
286678 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
286770 dotnet/runtime PayloadGroup0.WorkItemExecution
286571 dotnet/runtime PayloadGroup0.WorkItemExecution #86774
286477 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
286471 dotnet/runtime PayloadGroup0.WorkItemExecution #86698
286355 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
286197 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85317
284737 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86705
285977 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86656
285914 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86698
285748 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
285659 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #84191
285627 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
285516 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
285547 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86655
285563 dotnet/runtime PayloadGroup0.WorkItemExecution #85373
285487 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
284740 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86705
284750 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86706
284602 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86551
284640 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #71426
284501 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
284476 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
284484 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86689
284420 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86688
284380 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86678
284372 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85558
284341 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
284137 dotnet/runtime PayloadGroup0.WorkItemExecution #86673
284145 dotnet/runtime PayloadGroup0.WorkItemExecution #86530
284085 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86669
284008 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86668
283533 dotnet/runtime PayloadGroup0.WorkItemExecution #86551
283741 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86656
283677 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #84926
283583 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85551
283568 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #84926
283520 dotnet/runtime PayloadGroup0.WorkItemExecution #86582
283446 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85317
283334 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86245
283279 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86638
283262 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86637
283222 dotnet/runtime PayloadGroup0.WorkItemExecution #86632
283086 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #85317
282951 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
282855 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
282864 dotnet/runtime GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh #86610
Displaying 100 of 108 results

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 61 108
@elinor-fung elinor-fung added area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels May 22, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=282177
Build error leg or test failing: GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
Pull request: #86598

GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh [FAIL]
      
  Assert failure(PID 85618 [0x00014e72], Thread: 3483931 [0x35291b]): !gradual_decommit_in_progress_p || (seg != ephemeral_heap_segment) || (heap_segment_committed (seg) <= heap_segment_decommit_target (seg))
      File: /Users/runner/work/1/s/src/coreclr/gc/gc.cpp Line: 14989
      Image: /private/tmp/helix/working/AE9E0917/p/corerun

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "!gradual_decommit_in_progress_p || (seg != ephemeral_heap_segment) || (heap_segment_committed (seg) <= heap_segment_decommit_target (seg))",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Author: elinor-fung
Assignees: -
Labels:

area-GC-coreclr, blocking-clean-ci, Known Build Error

Milestone: -

@Maoni0
Copy link
Member

Maoni0 commented May 23, 2023

this is because of 84975. I see we missed a case with segments. for segments if we are triggering a GC because of the NoGCRegion mode, we can call grow_heap_segment which could trigger this assert. we should also turn off gradual_decommit_in_progress_p in should_proceed_for_no_gc.

PeterSolMS added a commit that referenced this issue May 23, 2023
This addresses issue #86612.

We won't actually decommit anything once we enter a no GC region, so the assert was overeager for this case, but it seems better to keep the assert and turn off the gradual_decommit_in_progress_p flag when we enter a no GC region.
@EgorBo
Copy link
Member

EgorBo commented May 24, 2023

The issue is still there it seems

@mangod9
Copy link
Member

mangod9 commented May 24, 2023

@PeterSolMS could you please take a look at this?

@EgorBo
Copy link
Member

EgorBo commented May 24, 2023

E.g. reproduces in today's #86705

@mangod9
Copy link
Member

mangod9 commented May 30, 2023

Should be fixed by #86889

@mangod9
Copy link
Member

mangod9 commented Jun 1, 2023

Looks like no hit count in the last 24 hours. So assume its Ok to close?

@EgorBo
Copy link
Member

EgorBo commented Jun 1, 2023

Looks like no hit count in the last 24 hours. So assume its Ok to close?

Agree

@mangod9
Copy link
Member

mangod9 commented Jun 1, 2023

Closing since the failure is now fixed.

@mangod9 mangod9 closed this as completed Jun 1, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jun 1, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-GC-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

4 participants