-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert failure in GC/API/NoGCRegion/Callback_Svr test #86612
Comments
Tagging subscribers to this area: @dotnet/gc Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=282177
Error MessageFill the error message using known issues guidance. {
"ErrorMessage": "!gradual_decommit_in_progress_p || (seg != ephemeral_heap_segment) || (heap_segment_committed (seg) <= heap_segment_decommit_target (seg))",
"BuildRetry": false,
"ExcludeConsoleLog": false
}
|
this is because of 84975. I see we missed a case with segments. for segments if we are triggering a GC because of the NoGCRegion mode, we can call |
This addresses issue #86612. We won't actually decommit anything once we enter a no GC region, so the assert was overeager for this case, but it seems better to keep the assert and turn off the gradual_decommit_in_progress_p flag when we enter a no GC region.
The issue is still there it seems |
@PeterSolMS could you please take a look at this? |
E.g. reproduces in today's #86705 |
Should be fixed by #86889 |
Looks like no hit count in the last 24 hours. So assume its Ok to close? |
Agree |
Closing since the failure is now fixed. |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=282177
Build error leg or test failing: GC/API/NoGCRegion/Callback_Svr/Callback_Svr.sh
Pull request: #86598
Error Message
Fill the error message using known issues guidance.
Report
Summary
The text was updated successfully, but these errors were encountered: