Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Fix debug flowgraph check for un-compacted blocks #103904

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

amanasifkhalid
Copy link
Member

Fixes #103875. When checking for un-compacted blocks, make sure we don't assert for cases that were purposefully left un-compacted to avoid churning the flowgraph late in the JIT's phases.

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Thanks!

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2024
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid
Copy link
Member Author

x86 jitstress failure is a timeout in GC tests, all other jitstress failures are #103577.

@amanasifkhalid amanasifkhalid merged commit bed1751 into dotnet:main Jun 24, 2024
114 of 125 checks passed
@amanasifkhalid amanasifkhalid deleted the fix-compaction-check branch June 24, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: GC/LargeMemory/Regressions/largearraytest/largearraytest.sh
2 participants