Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeDom null annotations fixes #90393

Closed
wants to merge 3 commits into from
Closed

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Aug 11, 2023

This is a first step towards fixing #78036. Here, I fix three classes identified to have false annotations today. I hope to get some feedback from the team to see if I'm heading in the right direction.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 11, 2023
@ghost
Copy link

ghost commented Aug 11, 2023

Tagging subscribers to this area: @dotnet/area-system-codedom
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a first step towards fixing #78036. Here, I fix three classes identified to have false annotations today. I hope to get some feedback from the team to see if I'm heading in the right direction.

Author: halgab
Assignees: -
Labels:

area-System.CodeDom, community-contribution

Milestone: -

@steveharter
Copy link
Member

Closing since #90401 disabled nullability for System.CodeDom. We can work on a full nullability approach in v9.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.CodeDom community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants