Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate including dotnet/icu in source-build 5.0 #1792

Closed
dagood opened this issue Oct 7, 2020 · 1 comment
Closed

Investigate including dotnet/icu in source-build 5.0 #1792

dagood opened this issue Oct 7, 2020 · 1 comment
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball

Comments

@dagood
Copy link
Member

dagood commented Oct 7, 2020

https://github.com/dotnet/icu showed up as a dotnet/runtime dependency between 5.0 preview 7 and 5.0 preview 8:
https://github.com/dotnet/runtime/blob/v5.0.0-preview.8.20407.11/eng/Version.Details.xml#L7-L10
dotnet/runtime@8c1792d

Based on that, it looks like a browser-wasm dependency. It might not be necessary for 5.0--we don't think we can build our own browser-wasm runtime pack yet (#1721), and runtime packs in general can't even be distributed in the SDK (#1215), so everyone will use the Microsoft-built one from nuget.org for Blazor.

If dotnet/icu bits somehow end up inside the SDK, though, rather than just the runtime pack, we will need to do this to remove prebuilts.

@dagood dagood added the area-prebuilts Reducing the number of prebuilt packages in the tarball label Oct 7, 2020
@dseefeld
Copy link
Contributor

dseefeld commented Oct 8, 2020

Doesn't appear that this is needed for source-build 5.0, since we're not building browser-wasm runtime pack. If prebuilts happen to appear for this because of other dependencies, it can be addressed then.

@dseefeld dseefeld closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball
Projects
None yet
Development

No branches or pull requests

2 participants