Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to quiet orchestrations #8

Open
jacknoble opened this issue May 1, 2022 · 1 comment
Open

Ability to quiet orchestrations #8

jacknoble opened this issue May 1, 2022 · 1 comment

Comments

@jacknoble
Copy link
Member

Sidekiq has the ability to quiet jobs (e.g. keep new jobs from be enqueued) enabling graceful shutdown. Because orchestrations contain jobs that are often coupled to each other code changes can be painful. If you have an orchestration like:

run JobB
run JobA

And move work from JobB to JobA when you deploy you might have JobB jobs already queued. When your updated code starts running the queued JobB jobs will run but you'll lose the work that you've moved to JobA. For these reasons a convenient tool would be the ability to stop starting new orchestrations. You can then wait for your running orchestrations to finish before making your code changes.

@jcwilk
Copy link
Contributor

jcwilk commented May 4, 2023

This sounds like something which might be more appropriate to be application-level rather than simplekiq-level since it's unlikely that an application would be able to silently endure missing orchestrations without negative side effects unless there was some sort of deferring process which would seemingly need to be infrastructure-specific.

Let's leave it open for now though to see if others have a similar ask and whether we might be able to find something that makes sense to be simplekiq-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants