all checks complete 2

NEWS.md

@@ -9,12 +9,10 @@ title: "NEWS"
 
 
 ### CRAN submission v2.1.3
-* TBA Issue 90
-* TBS Issue 89
-* Entry errors in Excel file
-* Warnings on using FOMs that depend on only non-diseased cases or only diseased cases 
-* Refer to `QuickStart`: new chapter on recommended FOMs and those to avoid at all costs
-* Just provide a brief description in code and a link to the new chapter (which is under construction)
+* Bug fix, Issue 90, see below
+* Bug fix, Issue 89, see below
+* Fixed entry errors in Excel file (check column names and data type)
+* TODO: `QuickStart`, new chapter on recommended FOMs and those to avoid at all costs
 
 
 ### Issue 90
@@ -35,14 +33,13 @@ title: "NEWS"
 * Fixed FROC simulator, easier to read code; both simulators are NOT limited to I = 2.
 * This affected `goodValues`; reinitialized affected ones.
 * Extended Obuchowski's idea - tested with rudimentary FROC simulator; works!
-* `truthTableStr` is used more consistently except for LROC and ROI paradigms.
+* `truthTableStr` is used more consistently (except for LROC and ROI paradigms).
 * TODO: see below
 
 
 ### Changes 05/18/2023
 * Added Obuchowski's idea - tested with rudimentary ROC simulator; works!
 * `truthTableStr` is used inconsistently.
-* TODO: find all occurrences of "05/18/2023" and `truthTableStr` and check code.
 * TODO: `dataset11` fails RSM fitting; `mu` close to zero for several readers as minimum 3 op. points are clustered into effectively two op. points.
 * TODO: Fix `datasets.R`
 

inst/cranSubmission/cran-comments-2.1.3.md

@@ -3,7 +3,7 @@ title: "CRAN comments"
 ---
 
 
-# Reason for submission1
+# Reason for submission
 * This submission is in response to two user-reported bugs documented as Issues here:
 
     + https://github.com/dpc10ster/RJafroc/issues/89
@@ -14,28 +14,39 @@ title: "CRAN comments"
 
 # Test environments
 
-## My machine
+## My machines
+
+### Apple M2 Pro
 
-* Apple M2 Pro
 * macOS Ventura 13.4.1 (c)
 * Platform: aarch64-apple-darwin20
 * R version 4.3.0 (2023-04-21)
 
-## R CMD checks on my machine
+### Checks on this machine
+
+* `R CMD check` in `RStudio`: OK
+
+
+### Apple iMac
 
-* `R CMD check` in RStudio ran with no errors, warnings or notes
-* `devtools::check()` ran with no errors, warnings or notes
+* macOS Catalina 10.15.7
+* Platform: x86_64-apple-darwin17.0
+* R version 4.2.3 (2023-03-15)
 
+### Checks on this machine
 
-## R CMD checks on GitHub Actions
+* `R CMD check` in `RStudio`: OK
+
+
+## Checks on GitHub Actions
 
 * windows-latest (release): OK
 * macOS-latest (release):  OK
 * ubuntu-20.04 (release): OK
 * ubuntu-20.04 (devel): OK
 
 
-## Windows and MAC portability were checked using `devtools`
+## Windows and MAC portability were checked
 
 `devtools::check_win_devel()`: OK
 `devtools::check_win_release()`: OK
@@ -54,10 +65,11 @@ title: "CRAN comments"
 |https://builder.r-hub.io/status/RJafroc_2.1.3.tar.gz-30c816b4e9774a849aeada1e6071f967 | ERROR \**see below                                        |
 
 `*` package ‘V8’ not available on this platform.
+
 `**` package dependencies ‘openxlsx’ and ‘readxl’ are not available on this platform.
 
 
-## Summary of checks on other platform using package `rhub`
+## Checks on other platform using package `rhub`
 
 ```
 library(rhub)
@@ -75,11 +87,10 @@ rhub::check()
 | Fedora Linux, R-devel, GCC                               | NOTE installed size 5.7Mb                             |
 | Windows Server 2022, R-devel, 64 bit                     | OK                                                    |
 | Debian Linux, R-patched, GCC                             | OK                                                    |
-| Debian Linux, R-release, GCC                             | NOTE Installed size 5.1Mb                                |
+| Debian Linux, R-release, GCC                             | NOTE Installed size 5.1Mb                             |
 | Windows Server 2022, R-release, 32/64 bit                | OK                                                    |
 | Windows Server 2022, R-oldrel, 32/64 bit                 | OK                                                    |
 
-`*` package dependencies ‘openxlsx’ and ‘readxl’ are not available on this platform.
 
 
 # FAILURE SUMMARY from last attempted submission

inst/cranSubmission/cranSubmission.R

@@ -5,27 +5,39 @@
 
 library(rhub)
 
+
 # CRAN check flavors
 # https://cran.r-project.org/web/checks/check_flavors.html
 
-platf <- rhub::platforms()
-
-indx_packages_cran <- c(1,2,6,7,12,4,5,15,13)
-
-packagePath <- "/Users/Dev/GitHub/RJafroc_2.1.3.tar.gz"
-if (!file.exists(packagePath))
-  packagePath <- devtools::build()
-
+#
+# platf <- rhub::platforms()
+# 
+# indx_packages_cran <- c(1,2,6,7,12,4,5,15,13)
+# 
+# packagePath <- "/Users/Dev/GitHub/RJafroc_2.1.3.tar.gz"
+# if (!file.exists(packagePath))
+#   packagePath <- devtools::build()
+# 
 ##
-## RUN in Terminal window on iMac
+## RUN in Terminal window
 ## caffeinate -d
 ## 
 
-for (i in 6:length(indx_packages_cran)) {
-  descr <- platf$description[indx_packages_cran[i]]
-  name <- platf$name[indx_packages_cran[i]]
-  cat(descr,"\n")
-  chk1 <- rhub::check(path = packagePath, platforms = name)
-  next
-}
-
+rhub::validate_email()
+rhub::check() # then select platform from menu
+
+# 1: Debian Linux, R-devel, clang, ISO-8859-15 locale (debian-clang-devel)
+# 2: Debian Linux, R-devel, GCC (debian-gcc-devel)
+# 3: Debian Linux, R-devel, GCC, no long double (debian-gcc-devel-nold)
+# 4: Debian Linux, R-patched, GCC (debian-gcc-patched)
+# 5: Debian Linux, R-release, GCC (debian-gcc-release)
+# 6: Fedora Linux, R-devel, clang, gfortran (fedora-clang-devel)
+# 7: Fedora Linux, R-devel, GCC (fedora-gcc-devel)
+# 8: Debian Linux, R-devel, GCC ASAN/UBSAN (linux-x86_64-rocker-gcc-san)
+# 9: Ubuntu Linux 20.04.1 LTS, R-devel, GCC (ubuntu-gcc-devel)
+# 10: Ubuntu Linux 20.04.1 LTS, R-release, GCC (ubuntu-gcc-release)
+# 11: Ubuntu Linux 20.04.1 LTS, R-devel with rchk (ubuntu-rchk)
+# 12: Windows Server 2022, R-devel, 64 bit (windows-x86_64-devel)
+# 13: Windows Server 2022, R-oldrel, 32/64 bit (windows-x86_64-oldrel)
+# 14: Windows Server 2022, R-patched, 32/64 bit (windows-x86_64-patched)
+# 15: Windows Server 2022, R-release, 32/64 bit (windows-x86_64-release)