-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential import collision: import path should be "gopkg.in/h2non/gock.v1", not "github.com/h2non/gock". #69
Comments
@bradrydzewski @chhsia0 Could you help me review this issue? Thx :p |
Gock is not using any imports for itself, so both imports are working. This library doesn't really need the old gopkg.in behavior because of Go modules. So I don't see a big need to change that now. |
@tboerger it looks like the |
Thank you for your reply! @tboerger @bradrydzewski
|
Background
The
h2non/gock
has already renamed it’s import path from "github.com/h2non/gock" to "gopkg.in/h2non/gock.v1".As README of
h2non/gock
v1.0.9 said, downstream repos should use "gopkg.in/h2non/gock.v1" to get or importh2non/gock
.But
drone/go-scm
still used the old path:https://github.com/drone/go-scm/blob/master/go.mod#L5
When you use the old path "github.com/h2non/gock" to import the
h2non/gock
, it will be very easy to reintroduceh2non/gock through the import statements "import gopkg.in/h2non/gock.v1" in the go source file of
h2non/gock`.https://github.com/h2non/gock/blob/v1.0.9/_examples/custom_matcher/matcher.go#L5
The "gopkg.in/h2non/gock.v1" and "github.com/h2non/gock" are the same repos. This will work in isolation, bring about potential risks and problems.
So, why not get rid of the old import path "github.com/h2non/gock ", use "gopkg.in/h2non/gock.v1" instead.
Solution
Replace all the old import paths, change
"github.com/h2non/gock"
to"gopkg.in/h2non/gock.v1"
.Where did you import it: https://github.com/drone/go-scm/search?q=github.com%2Fh2non%2Fgock&unscoped_q=github.com%2Fh2non%2Fgock
The text was updated successfully, but these errors were encountered: