Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text to the red line mouseover tooltip and remove 'Center RX' button #741

Closed
barjac opened this issue Aug 26, 2024 · 15 comments
Closed

Comments

@barjac
Copy link

barjac commented Aug 26, 2024

Suggestions:
Change the red line mouseover tooltip to read:
"Double click to tune, middle click to re-center"
I suspect most users don't know about this feature.

Then, I really don't see any need for the 'Center RX' button as it duplicates the the above action.
This button is causing the main window to generate four left widget columns prematurely when reducing the window height compared to the situation before it was added.
When monitoring an SDR the space below the reporter was previously greater allowing more room for display of the SDR waterfall on a high aspect ratio screen like this laptop, whilst keeping only three widget columns each side of a good width 'scope widget.

This is just after the fourth left column is created when reducing height. 'Record' has been pushed into a new column by 'Center RX'.
Screenshot_20240826_101253

@tmiw
Copy link
Collaborator

tmiw commented Aug 27, 2024

This might be something DE-specific since I can shrink the window a fair bit before it goes to four columns. Example from GNOME:

image

Also tried on macOS and got similar results. I'm not really sure why there's such a massive difference in behavior, unfortunately.


On a more general note, is middle-click something that would be easy enough to find if that became the only way to re-center? I get that there'd be a tooltip but that'd also require someone to put their mouse over that area first.

@barjac
Copy link
Author

barjac commented Aug 28, 2024

On a more general note, is middle-click something that would be easy enough to find if that became the only way to re-center? I get that there'd be a tooltip but that'd also require someone to put their mouse over that area first.

Surely if they are adjusting the red line to re-tune RX then they already have the mouse over it, so the tooltip would appear anyway :)

Also it is inconvenient to have to move the mouse over to the 'Centre RX' button and back to the red line area to do this. Adjusting the tuning is a delicate operation and it is much more convenient to swap mouse buttons than move the mouse.

I really think that the button is superfluous clutter irrespective of any display issue.

@Tyrbiter
Copy link

Does anyone ever use the ReSync button these days? I don't think I would miss it.

@barjac
Copy link
Author

barjac commented Aug 28, 2024

Does anyone ever use the ReSync button these days? I don't think I would miss it.

I have used it but not really sure whether it actually did anything that would not have been done automatically.
Are you saying that you would prefer to lose the Re-sync button rather than Re-center or would you be OK to lose both?

@Tyrbiter
Copy link

Does anyone ever use the ReSync button these days? I don't think I would miss it.

I have used it but not really sure whether it actually did anything that would not have been done automatically. Are you saying that you would prefer to lose the Re-sync button rather than Re-center or would you be OK to lose both?

If the ReSync button is of no use, removing it would make the Record button remain below it and keep the 3 column view.

I can see that the Center Rx button is somewhat out of place, but having it advertised only in a tooltip makes it more difficult to find.

@tmiw
Copy link
Collaborator

tmiw commented Aug 28, 2024

What if "Sync" was renamed to something else? Would that make the buttons fit better (assuming they were kept)?

@barjac
Copy link
Author

barjac commented Aug 29, 2024

What if "Sync" was renamed to something else? Would that make the buttons fit better (assuming they were kept)?

If you mean ReSync then considering that all the buttons are the same height I don't see how that would change anything.

@barjac
Copy link
Author

barjac commented Aug 29, 2024

I can see that the Center Rx button is somewhat out of place, but having it advertised only in a tooltip makes it more difficult to find.

The "double click to tune" is only advertised in the tooltip so why should this be any different?

@Tyrbiter
Copy link

I can see that the Center Rx button is somewhat out of place, but having it advertised only in a tooltip makes it more difficult to find.

The "double click to tune" is only advertised in the tooltip so why should this be any different?

Well it's not really any different, I suppose it depends on how much you use these facilities. I find it useful to see what the modem thinks the centre frequency is but I rarely need to tune or re-centre because almost every signal I hear is bang on the nominal frequency. Reference oscillators are much more accurate over the long term than they used to be.

@tmiw
Copy link
Collaborator

tmiw commented Aug 31, 2024

I just realized--I'm not actually sure how to do middle-click on macOS without an external mouse. That might mean that the "Center RX". button still needs to stick around for that scenario. The addition to the tooltip isn't a huge deal, though, so I'll go ahead and at least do that.

EDIT: #743

@barjac
Copy link
Author

barjac commented Sep 1, 2024

I just realized--I'm not actually sure how to do middle-click on macOS without an external mouse. That might mean that the "Center RX". button still needs to stick around for that scenario.

Oops!

The addition to the tooltip isn't a huge deal, though, so I'll go ahead and at least do that.

EDIT: #743

Thanks :)

@tmiw
Copy link
Collaborator

tmiw commented Sep 2, 2024

So yeah, do you know anyone who uses the ReSync button? If we're going to remove anything, that's the most likely candidate IMO (although it is still weird that this only seems to be a problem with KDE Plasma for some reason).

@tmiw
Copy link
Collaborator

tmiw commented Sep 8, 2024

Just pinging everyone. Any other work needed or can I just merge #743 as-is?

@Tyrbiter
Copy link

Tyrbiter commented Sep 8, 2024

My only suggestion, aimed at @barjac and his screen estate requirements, is possibly moving the Resync button to a menu item if that's not too difficult. I don't use it, and have not heard anyone else say that they do.

Otherwise if this is seen as unnecessary I don't have any issues as it stands.

tmiw added a commit that referenced this issue Sep 12, 2024
Adjust waterfall/spectrum tooltip based on issue #741.
@tmiw
Copy link
Collaborator

tmiw commented Sep 12, 2024

Merged the change for the tooltips and am closing for now. Let me know if you'd like this reopened.

@tmiw tmiw closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants