Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMNetworkAdapter: Should be able to ignore network settings #204

Closed
johlju opened this issue Jun 23, 2022 · 0 comments · Fixed by #205
Closed

VMNetworkAdapter: Should be able to ignore network settings #204

johlju opened this issue Jun 23, 2022 · 0 comments · Fixed by #205
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jun 23, 2022 •
edited
Loading

Should we also add a property Dhcp in the schema class NetworkSettings so we can easily determine if DHCP or static IP should be used? That I think would cover the scenarios:

  • If NetworkSettings parameter is not part of configuration, do not enforce IP (DHCP or Static).
  • If NetworkSettings parameter is passed
    • and contain DHCP -eq $true then enable DHCP.
    • and contain DHCP -eq $false then use Static IP.

Since we have renamed the resources and are releasing the module as a new major version we can also add this as a breaking change.

Originally posted by @johlju in #189 (comment)
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub breaking change When used on an issue, the issue has been determined to be a breaking change. labels Jun 23, 2022
@stehlih stehlih mentioned this issue Jul 15, 2022
Merged
9 tasks
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VMNetworkAdapter: fix some issues on NetworkSetting parameter stehlih/xHyper-V
1 participant
@johlju