-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action of mpa.compress()
without arguments
#35
Comments
But why would you want to call compress in the first place if you don't want to compress?
|
I like your off-line suggestion of using |
I expected that
mpa.compress()
without arguments would not perform compression except maybe ensure normalization. This would be useful in order to make compression optional: No arguments cause no compression to be performed.However, both
mpa.compress()
andmpa.compression()
perform SVD compression withoutbdim
andrelerr
, i.e. they truncate singular values which are equal to zero. This does not occur frequently. In many cases, this will not reduce the bond dimension by more than a simplempa.normalize()
and CPU time is wasted.I suggest to change change the two methods to not run SVD compression if
method='SVD'
is not specified. @dseuss, do you agree?The text was updated successfully, but these errors were encountered: