Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for point fill and border thickness in scatterPlot #18

Open
j-andrews7 opened this issue Jul 6, 2024 · 1 comment
Open

Support for point fill and border thickness in scatterPlot #18

j-andrews7 opened this issue Jul 6, 2024 · 1 comment

Comments

@j-andrews7
Copy link
Contributor

E.g.

df <- data.frame(id=runif(12), x=1:12, y=runif(12))
ggplot(df, aes(x=x, y=y)) + 
  geom_point(aes(fill=id, size=id), colour="black", shape=21, stroke = 2)

image

This would require some adjustments to how color.by is interpreted (to switch it to populate the fill aes instead) and addition of parameters to control stroke width and color (when fill is populated rather than color by color.by). Potentially confusing changes, as we'd only want it to work with the open shapes (21-25).

Would be interested in how you'd prefer something like this be implemented.

@dtm2451
Copy link
Owner

dtm2451 commented Jul 9, 2024

I'll have to think about this some more. But yea, maybe something like outline.size and outline.color for the inputs? Maybe with '.by' too... I think it'd be nice to let these be populated from a column if the value given matches a column name. Probably both default to NULL and when they are left NULL is when the current system stays.

For shape switching... perhaps the shape.panel default value should change to NA and, unless set by the user, it then gets filled in with a different set of shapes depending on which coloring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants