Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output is unreadable if the terminal uses black text on white background #209

Open
RalfJung opened this issue Feb 28, 2024 · 5 comments
Open

Comments

@RalfJung
Copy link

Here's a sample screenshot of how cargo expand output looks for me:

image

As you can tell, that's pretty much useless. I have to copy-paste it into an editor to get rid of the formatting and see all the white characters on white background.

@ZymoticB
Copy link

https://github.com/dtolnay/cargo-expand?tab=readme-ov-file#configuration

You can use a different theme, there are some suggestions for light backgrounds in the upstream readme https://github.com/sharkdp/bat?tab=readme-ov-file#highlighting-theme

@RalfJung
Copy link
Author

Seems not great to require users to do manual configuration to be able to read anything. I have not yet encountered this with any other application. (Some, e.g. aptitude, just overwrite all colors so they are still white-on-black despite by black-on-white terminal theme. But that's fine, the application at least remains usable.)

@maciek134
Copy link

Can't the default theme be set to use 4bit colors to avoid overriding the terminal color scheme?

@grothesque
Copy link

I would like to add that research shows that reading dark text on a light background is physiologically preferable in most circumstances. A default that doesn't work unless one follows current fashion may not be the best choice.

@tv42
Copy link

tv42 commented Dec 10, 2024

For some reason, trying to undo the unreadable theme in ~/.cargo/config.toml doesn't work. --theme none on command line does.

Here's my vote for having the simple, always-correct, thing be the default.
Every single one of the themes is unreadably low-contrast in my terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants