Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fillMaxSize는 contentPadding을 보존하며 적용돼야 함 #698

Open
jisungbin opened this issue May 18, 2023 · 0 comments
Open

fillMaxSize는 contentPadding을 보존하며 적용돼야 함 #698

jisungbin opened this issue May 18, 2023 · 0 comments
Assignees
@jisungbin
Labels
bug Something isn't working ui

Comments

@jisungbin
Copy link
Contributor

Modifier#fillMaxSize는 사이즈 하드코딩 요소가 아니므로 contentPadding: QuackPadding 값을 보존하며 적용되어야 함

Modifier.fillMaxSize()를 사용하면 Size.kt에 있는 FillWholeMaxWidth가 combine 되는 데 이걸 응용하면 별도의 꽥꽥 API 없이 이 작업을 할 수 있을 듯 함
@jisungbin jisungbin added bug Something isn't working help wanted Extra attention is needed ui labels May 18, 2023
@jisungbin jisungbin self-assigned this May 18, 2023
@jisungbin jisungbin changed the title fillMaxSize는 contentPadding(QuackPadding)을 보존하며 적용돼야 함 fillMaxSize는 contentPadding을 보존하며 적용돼야 함 May 18, 2023
@jisungbin jisungbin moved this to 🆕 New (Enhancement) in QuackQuack-v2 May 18, 2023
@jisungbin jisungbin moved this from 🆕 New (Enhancement) to 🐛 Bug in QuackQuack-v2 May 18, 2023
@jisungbin jisungbin moved this from 🐛 Bug to 🏗 In Progress in QuackQuack-v2 May 22, 2023
jisungbin added a commit that referenced this issue May 22, 2023
@jisungbin
reflectivelyFillMaxSizeOperationHashCode
6e844c0 
cc #698
@jisungbin jisungbin moved this from 🏗 In Progress to 📋 Backlog in QuackQuack-v2 May 24, 2023
@jisungbin jisungbin moved this from 📋 Backlog to 🏗 In Progress in QuackQuack-v2 May 24, 2023
@jisungbin jisungbin moved this from 🏗 In Progress to 📋 Backlog in QuackQuack-v2 May 24, 2023
@jisungbin jisungbin removed the help wanted Extra attention is needed label May 24, 2023
@jisungbin jisungbin moved this from 📋 Backlog to 🐛 Bug in QuackQuack-v2 Jun 9, 2023
@jisungbin jisungbin moved this from 🐛 Bug to 🏗 In Progress in QuackQuack-v2 Jun 21, 2023
@jisungbin jisungbin moved this from 🏗 In Progress to 📋 Backlog in QuackQuack-v2 Jul 1, 2023
@jisungbin jisungbin moved this from 📋 Backlog to 🆕 New (Enhancement) in QuackQuack-v2 Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jisungbin jisungbin

Labels
bug Something isn't working ui
Projects
QuackQuack-v2
Status: 🆕 New (Enhancement)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jisungbin