Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should any key expire while there are still grabbed keys out? #61

Open
pelletencate opened this issue May 8, 2019 · 0 comments
Open

Should any key expire while there are still grabbed keys out? #61

pelletencate opened this issue May 8, 2019 · 0 comments

Comments

@pelletencate
Copy link

pelletencate commented May 8, 2019 •
edited
Loading

It seems right now that when a grabbed token is released after the keys have expired, that that single token is returned to the available pool which contains then only that token, all the while the Exists and Version keys are gone. That sounds wrong.

Wouldn't it make more sense to have #lock call persist on all keys, and #signal only expire them if it just signaled out the last grabbed key?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pelletencate