[PY] v0.6.6 only cancel Short-Term orders, break stateful order cancellations #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-dydx
commented
Sep 20, 2023
| @@ -155,8 +155,7 @@ def compose_msg_cancel_order( | |||
| ) | |||
| return MsgCancelOrder( | |||
| order_id=order_id, | |||
| good_til_block=good_til_block, | |||
| good_til_block_time=good_til_block_time | |||
| good_til_block=good_til_block | |||
There was a problem hiding this comment.
To avoid overwriting the good_til_block attribute, the good_til_block_time attribute is unset.
This temporarily breaks stateful order cancellations, the tradeoff is considered worth it since the Python client shouldn't be used for stateful order placements or cancellations.
There was a problem hiding this comment.
Is there a discussion thread somewhere? If so can you link
Do we have a tracking item to fix stateful order cancellations?
There was a problem hiding this comment.
It's in the slack thread. This python client isn't used for stateful order cancellations at all, it should only be used by programmatic traders.
teddyding
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick hack to get MM testnet onboarding unblocked. This should be fine since the Python client is not used by the frontend, and therefore doesn't send stateful order cancellations.
Slack thread for context.